fix: use named imports for terser.minify #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I've no idea why the CI's failing……Just ran it on a Windows VM and everything works perfectly. |
TrySound
approved these changes
Feb 3, 2019
|
@evilebottnawi can you also update the direct dependency to the latest version? I'm not sure how this will affect compat with older versions. |
|
@filipesilva WIP |
dudiharush
added a commit
to dudiharush/webpack
that referenced
this pull request
Feb 4, 2019
Need to update plugin version, which fixes this bug: webpack-contrib/terser-webpack-plugin#69
This was referenced Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #66, #67
Named imports have better interoperability than default imports and it is applicable to all versions of terser.