Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update terser to version 4 #94

Closed
wants to merge 1 commit into from
Closed

feat: update terser to version 4 #94

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

Full terser changelog https://github.com/terser-js/terser/blob/master/CHANGELOG.md#v400

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files           5        5           
  Lines         283      283           
  Branches      113      113           
=======================================
  Hits          278      278           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7aaa7...6f9ce31. Read the comment docs.

@alexander-akait
Copy link
Member

Ci fail

@alan-agius4
Copy link
Author

@alexander-akait
Copy link
Member

@alexander-akait
Copy link
Member

/cc @fabiosantoscode it is safe to release as minor version, not major (we require node@6)?

@fabiosantoscode
Copy link
Contributor

@evilebottnawi The internal AST has changed. If you allow your users to access the internal AST like this then it's a major change.

@alexander-akait
Copy link
Member

Thanks, we don't allow developers use ast so it is minor release, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants