-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set SourceMap Value based on Webpack Config #95
Set SourceMap Value based on Webpack Config #95
Conversation
set the sourceMap property by checking webpack config - easier to configure terser
|
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 98.23% 98.25% +0.01%
==========================================
Files 5 5
Lines 283 286 +3
Branches 113 116 +3
==========================================
+ Hits 278 281 +3
Misses 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR, it is breaking change, so we will merge this for v2.0, anyway thanks for PR
Partial fixed for
because plugin doesn't support some devtool values, we try to fix it in webpack@5 and then fix it here Anyway thanks for PR |
This PR contains a:
Motivation / Use-Case
Basically when switching over to use
terser-webpack-plugin
I wasted some time trying to figure out why sourcemaps weren't working when I had configured it in the plugins for webpack, only to realize I needed to passsourceMap: true
to our TerserPlugin.I saw that the webpack defaults actually already do this, and it seems to make sense to do it here as well and remove the config.
#71
Breaking Changes
With this change, the default for
sourceMap
defers to the webpack configurationdevtool
or plugins that use theSourceMapDevToolPlugin
to define sourcemaps instead of defaulting tofalse
.Additional Info