Proper function to calculate number of workers correctly #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
===========================================
+ Coverage 0% 16.99% +16.99%
===========================================
Files 7 7
Lines 372 353 -19
Branches 66 58 -8
===========================================
+ Hits 0 60 +60
+ Misses 325 261 -64
+ Partials 47 32 -15
Continue to review full report at Codecov.
|
|
@evilebottnawi just applied the suggested simplification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some situations when
require('os').cpus()will returnundefined(nodejs/node#19022).This PR introduces a function to correctly calculate the number of workers or fallback it to 1 when it is not able to determine the correct number.
\CC @evilebottnawi