Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

UfligyJS un-necessarily pinned at the latest and buggy release #355

Closed
lukeapage opened this issue Sep 17, 2018 · 11 comments · Fixed by #357
Closed

UfligyJS un-necessarily pinned at the latest and buggy release #355

lukeapage opened this issue Sep 17, 2018 · 11 comments · Fixed by #357

Comments

@lukeapage
Copy link
Contributor

https://github.com/webpack-contrib/uglifyjs-webpack-plugin/blob/master/package.json#L50

pins uglify to 3.4.9

But there are some bad uglify-js bugs with 3.4.9:

mishoo/UglifyJS#3245
mishoo/UglifyJS#3257
mishoo/UglifyJS#3260

and now as a consumer of this plugin I cannot specify the uglify-js version in my parent package.json in order to use a non-buggy release.

@alexander-akait
Copy link
Member

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please either update the issue with the template and reopen, or open a new issue.

Also we use latest version of uglify-js, use lock file to avoid this situation. Also better use https://github.com/webpack-contrib/terser-webpack-plugin, he will be uses in webpack@5.

@alexander-akait
Copy link
Member

@lukeapage anyway we can decrease version to ^3.0.0, it is solve problem?

@alexander-akait
Copy link
Member

alexander-akait commented Sep 17, 2018

If yes, feel free to a send PR and we release patch version

lukeapage added a commit to lukeapage/uglifyjs-webpack-plugin that referenced this issue Sep 17, 2018
This allows users of the plugin to pin to older versions to avoid bugs.
3.1.4 picked purely because its in the package lock file as what handlebars pins to.
Fixes webpack-contrib#355
@lukeapage
Copy link
Contributor Author

Sure, done.

@Delagen
Copy link

Delagen commented Sep 18, 2018

I think it must be only in peerDependencies to control it outside package

@alexander-akait
Copy link
Member

@Delagen it is plugin, and he should use this as dependencies

@Delagen
Copy link

Delagen commented Sep 18, 2018

@evilebottnawi UglifyJS is very unstable at this branch, so it will broke project sometimes if version does not fix to certain revision

@alexander-akait
Copy link
Member

@Delagen use lock files

@alexander-akait
Copy link
Member

@Delagen
Copy link

Delagen commented Sep 18, 2018

@evilebottnawi Thanks for this recommendation. I'll try it

@alexander-akait
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants