Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for mjs #252

Merged
merged 6 commits into from
Mar 5, 2019
Merged

support for mjs #252

merged 6 commits into from
Mar 5, 2019

Conversation

jlopezxs
Copy link
Contributor

@jlopezxs jlopezxs commented Mar 4, 2019

@jsf-clabot
Copy link

jsf-clabot commented Mar 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@valscion
Copy link
Member

valscion commented Mar 5, 2019

Please remove yarn.lock. You will also need to sign the CLA

valscion
valscion reviewed Mar 5, 2019
View reviewed changes
src/analyzer.js Outdated Show resolved Hide resolved
jlopezxs and others added 2 commits March 5, 2019 10:13
@jlopezxs
Delete yarn.lock
0f758c0
@valscion @jlopezxs
Escape dot from extension
c0b2b03 
Co-Authored-By: jlopezxs <jlopezxs@gmail.com>
@valscion
Copy link
Member

valscion commented Mar 5, 2019

Thanks! Looks nice. Do you mind adding a new changelog entry right under the

## UNRELEASED

<!-- Add changelog entries for new changes under this section -->

<!-- comment?

valscion
valscion reviewed Mar 5, 2019
View reviewed changes
CHANGELOG.md Outdated
<!--
* **Improvement**
* Add support JS modules ([#252](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/252), [@jlopezxs](https://github.com/jlopezxs)))
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you don't need to add the new changelog entry in a comment ☺️. Only the "Add changelog entries" line needs to be a comment, new entries can be listed as is.

Also, what do you think if the wording was changed to "Add support for .mjs output files"? I fear that "support for JS modules" would cause people to think that webpack-bundle-analyzer didn't support JS modules as sources before. Because this PR is about supporting .mjs output files, right?

@valscion
Copy link
Member

valscion commented Mar 5, 2019

Looks good to me 👍. Thanks for contributing!

@valscion valscion merged commit a99fc91 into webpack-contrib:master Mar 5, 2019
@valscion valscion mentioned this pull request Mar 5, 2019
Closed
@danoc danoc mentioned this pull request Mar 11, 2019
Closed
@valscion
Copy link
Member

valscion commented Apr 6, 2019

This is now released in webpack-bundle-analyzer v3.2.0. Thank you for your contributions!

This was referenced Mar 11, 2021
Open
Merged
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 16, 2021
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valscion valscion valscion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlopezxs @jsf-clabot @valscion