Only copy URL to clipboard when !open #36
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 7 7
Lines 259 259
=======================================
Hits 238 238
Misses 21 21
Continue to review full report at Codecov.
|
|
CI wants me to add a test. Fair enough :) |
|
@shellscape how would you prefer me to test a config option like this? By adding a new config fixture to |
|
Should be able to sneak that into this test, just checking that the clipboard is empty: https://github.com/webpack-contrib/webpack-serve/blob/master/test/tests/options.js#L135 And you can modify the serve({ config }).then(({ close, options }) => { |
|
@billyjanitsch I just merged a PR that makes the clipboard stuff an option, so you'll probably need to rebase for that. We should also add a note to the README within the |
|
Awesome! Sorry for the delay on this PR, I'll finish it up today. |
|
@shellscape let me know how that looks -- happy to make further changes |
README.md
Outdated
| @@ -284,6 +284,8 @@ that matches: | |||
| } | |||
| ``` | |||
|
|
|||
| This option disables the `clipboard` option. | |||
There was a problem hiding this comment.
I'd change this to:
_Note: Using the `open` option will disable the `clipboard` option._For emphasis
test/tests/options.js
Outdated
|
|
||
| serve({ config }).then(({ close }) => { | ||
| hook = (...args) => { | ||
| assert.equal(clip.readSync(), 'foo'); |
There was a problem hiding this comment.
looks good 👍
can you add a comment above this line to note that it tests that the clipboard option is disabled when open is used?
|
@shellscape done, let me know if there's anything else! |
This PR contains a:
Motivation / Use-Case
This patch is a partial solution for #33: it disables the clipboard feature if the user has configured the
openoption (which clearly makes the clipboard feature redundant).It doesn't introduce a way to configure the clipboard feature or otherwise change the default, pending more discussion in #33.
Additional Info