Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme to reflect conditionNames default #359

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Oct 20, 2022

Fixes #358 by just documenting the actual default, rather than introducing a breaking change

@43081j
Copy link
Contributor Author

43081j commented Nov 10, 2022

@alexander-akait what do we need to do to merge this?

@alexander-akait
Copy link
Member

@sokra Friendly ping

@alexander-akait alexander-akait merged commit d4fb512 into webpack:main Apr 16, 2023
@43081j 43081j deleted the readme-update branch April 16, 2023 09:28
renovate bot referenced this pull request in Unleash/unleash Apr 29, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [enhanced-resolve](https://github.com/webpack/enhanced-resolve) |
[`5.12.0` ->
`5.13.0`](https://renovatebot.com/diffs/npm/enhanced-resolve/5.12.0/5.13.0)
|
[![age](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.13.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.13.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.13.0/compatibility-slim/5.12.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.13.0/confidence-slim/5.12.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>webpack/enhanced-resolve</summary>

###
[`v5.13.0`](https://github.com/webpack/enhanced-resolve/releases/tag/v5.13.0)

[Compare
Source](https://github.com/webpack/enhanced-resolve/compare/v5.12.0...v5.13.0)

#### Features

- Add `withFileTypes` options from FileSystem API by
[@&#8203;fu1996](https://github.com/fu1996) in
[https://github.com/webpack/enhanced-resolve/pull/374](https://github.com/webpack/enhanced-resolve/pull/374)

#### Bugfixes

- Support wildcards pattern with common suffix in imports/exports field
by [@&#8203;bvanjoi](https://github.com/bvanjoi) in
[https://github.com/webpack/enhanced-resolve/pull/353](https://github.com/webpack/enhanced-resolve/pull/353)

#### Dependencies

- Bump minimist from 1.2.5 to 1.2.8 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/webpack/enhanced-resolve/pull/373](https://github.com/webpack/enhanced-resolve/pull/373)
- Bump json5 from 2.1.3 to 2.2.3 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/webpack/enhanced-resolve/pull/371](https://github.com/webpack/enhanced-resolve/pull/371)

#### Developer Experience

- Clean up README example by
[@&#8203;wtlin1228](https://github.com/wtlin1228) in
[https://github.com/webpack/enhanced-resolve/pull/366](https://github.com/webpack/enhanced-resolve/pull/366)
- Update README to reflect `conditionNames` default by
[@&#8203;43081j](https://github.com/43081j) in
[https://github.com/webpack/enhanced-resolve/pull/359](https://github.com/webpack/enhanced-resolve/pull/359)

#### New Contributors

- [@&#8203;fu1996](https://github.com/fu1996) made their first
contribution in
[https://github.com/webpack/enhanced-resolve/pull/374](https://github.com/webpack/enhanced-resolve/pull/374)
- [@&#8203;wtlin1228](https://github.com/wtlin1228) made their first
contribution in
[https://github.com/webpack/enhanced-resolve/pull/366](https://github.com/webpack/enhanced-resolve/pull/366)
- [@&#8203;43081j](https://github.com/43081j) made their first
contribution in
[https://github.com/webpack/enhanced-resolve/pull/359](https://github.com/webpack/enhanced-resolve/pull/359)
- [@&#8203;bvanjoi](https://github.com/bvanjoi) made their first
contribution in
[https://github.com/webpack/enhanced-resolve/pull/353](https://github.com/webpack/enhanced-resolve/pull/353)

**Full Changelog**:
webpack/enhanced-resolve@v5.12.0...v5.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42My4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjMuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conditionNames defaults to ["node"] according to docs, but possibly doesn't actually
3 participants