Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: types #381

Merged
merged 25 commits into from
May 24, 2023
Merged

refactor: types #381

merged 25 commits into from
May 24, 2023

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 7, 2023

Add more types +strict mode, also update typescript and add commands to get coverage + fix async tests + improve ci

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Patch coverage: 87.75% and project coverage change: -0.06 ⚠️

Comparison is base (d5cb40e) 92.90% compared to head (76b2c9e) 92.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   92.90%   92.85%   -0.06%     
==========================================
  Files          43       43              
  Lines        2029     2042      +13     
  Branches      598      598              
==========================================
+ Hits         1885     1896      +11     
- Misses        116      118       +2     
  Partials       28       28              
Impacted Files Coverage Δ
lib/AliasPlugin.js 100.00% <ø> (ø)
lib/AppendPlugin.js 100.00% <ø> (ø)
lib/DescriptionFilePlugin.js 100.00% <ø> (ø)
lib/ExtensionAliasPlugin.js 97.22% <ø> (ø)
lib/LogInfoPlugin.js 0.00% <ø> (ø)
lib/ModulesInRootPlugin.js 100.00% <ø> (ø)
lib/ParsePlugin.js 96.77% <ø> (ø)
lib/RestrictionsPlugin.js 100.00% <ø> (ø)
lib/RootsPlugin.js 100.00% <ø> (ø)
lib/SelfReferencePlugin.js 96.29% <ø> (ø)
... and 27 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait marked this pull request as ready for review May 17, 2023 01:09
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheLarkInn TheLarkInn merged commit 617b37a into main May 24, 2023
@TheLarkInn TheLarkInn deleted the refactor-types branch May 24, 2023 14:09
renovate bot referenced this pull request in Unleash/unleash Jun 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [enhanced-resolve](https://github.com/webpack/enhanced-resolve) |
[`5.14.0` ->
`5.14.1`](https://renovatebot.com/diffs/npm/enhanced-resolve/5.14.0/5.14.1)
|
[![age](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.14.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.14.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.14.1/compatibility-slim/5.14.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/enhanced-resolve/5.14.1/confidence-slim/5.14.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>webpack/enhanced-resolve</summary>

###
[`v5.14.1`](https://github.com/webpack/enhanced-resolve/releases/tag/v5.14.1)

[Compare
Source](https://github.com/webpack/enhanced-resolve/compare/v5.14.0...v5.14.1)

#### Bugfixes

- TypeScript `strict` mode is now enabled for `enhanced-resolve` by
[@&#8203;alexander-akait](https://github.com/alexander-akait) in
[https://github.com/webpack/enhanced-resolve/pull/381](https://github.com/webpack/enhanced-resolve/pull/381)

#### Dependencies & Maintenance

- Migrate to Jest by [@&#8203;snitin315](https://github.com/snitin315)
in
[https://github.com/webpack/enhanced-resolve/pull/379](https://github.com/webpack/enhanced-resolve/pull/379)
- Bump minimatch from 3.0.4 to 3.1.2 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/webpack/enhanced-resolve/pull/383](https://github.com/webpack/enhanced-resolve/pull/383)
- Add Badges in README by
[@&#8203;snitin315](https://github.com/snitin315) in
[https://github.com/webpack/enhanced-resolve/pull/386](https://github.com/webpack/enhanced-resolve/pull/386)

**Full Changelog**:
webpack/enhanced-resolve@v5.14.0...v5.14.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

4 participants