This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
fix: init publicPath to undefined
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebraw
approved these changes
May 5, 2017
|
It already has two to cover the feature in question, just changing how we init publicPath because of the issue mentioned in the PR that broke it. The problem was the strict check for |
|
Ok, cool. JS. 👍 |
michael-ciniawsky
approved these changes
May 5, 2017
😛| @@ -61,7 +61,7 @@ module.exports = function(content) { | |||
| } | |||
|
|
|||
| var publicPath = "__webpack_public_path__ + " + JSON.stringify(url); | |||
| if (config.publicPath !== false) { | |||
| if (config.publicPath !== undefined) { | |||
There was a problem hiding this comment.
if (!config.publicPath) {}Maybe even 'safer', but enterily a nitpick
|
Any news regarding this bug? |
|
@d3viant0ne @bebraw Is there anything left to do here/blocking this ? :) |
michael-ciniawsky
changed the title
publicPath to undefined
|
@michael-ciniawsky Nothing that I know of. |
alexander-akait
approved these changes
Jun 3, 2017
|
Please semver patch someone when time :) |
This was referenced Apr 23, 2020
This was referenced May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
If relevant, did you update the README?
Summary
Initializing
publicPathto false was preventing the new option from being used withwebpack-config-validatorSee comment in #145
Does this PR introduce a breaking change?
No
Other information
Fixes #158