Support [query] in interpolateName

[pajter]

This PR adds support for [query] in the template of interpolateName.

Some background: I want to load SVG files in CSS but pass query parameters to them to influence SVG properties such as fill etc. After some digging I found out that file-loader uses the interpolateName function in this lib, and that there's no way to use [query] in the template. Seemed to me like this would be nice to have and easy enough to support.

I'd love to get your feedback on this. Please let me know if there's anything I missed!

[jsf-clabot]

All committers have signed the CLA.

[pajter]

Seems that yarn is preventing tests in Node 4 from running.

[alexander-akait]

I think we can solve this in easy way, like:

const queryStringIdx = targetFile.indexOf('?');
let query = ''; 
if (queryStringIdx >= 0) {
  query= targetFile.slice(queryStringIdx);
}  

without

[pajter]

I'm not quite sure if I understood correctly. As far as I understand, the resourcePath and resourceQuery are two separate entities. I can't split the path by ?, but I was trying to remove the leading ? character. I updated the code to be a bit more verbose. I hope this is what you meant.

[alexander-akait]

Logic is simple, if name contains ?foo=bar we interpreted this as [query]

[pajter]

Could you elaborate on which name you mean? I can only get ?foo=bar from loaderContext.resourceQuery. I feel like I'm missing something.

[alexander-akait]

name - second argument for interpolateName

[alexander-akait]

Good job, one note

[alexander-akait]

Just for information, we move loader-utils logic inside webpack@5, so this module will be deprecated

[alexander-akait]

Need fix CI Problem

[pajter]

I found an issue on the error that Yarn is throwing in CI: yarnpkg/yarn#6619 (comment)

[pajter]

@evilebottnawi Anything I can help with?

I can update package.json to use npm run instead of yarn, which will fix the Yarn error in Node 4. But then eslint will error because it uses destructuring syntax. Then you'd probably have to downgrade ESLint to support Node 4, or skip the lint entirely in Node 4.

For what it's worth, I can run the Jest test suite in Node 4 and everything passes.

[pajter]

Actually, I checked a bit better and see that ESLint isn't even running in CI. It's just the yarn commands that are failing in Node 4. It will work with npm, but I'm not sure if you'd want to change that or wait for Yarn to fix its issue. Doesn't seem to have a lot of activity...

[alexander-akait]

@pajter ignore problem with node@4

[pajter]

Is this okay to merge then?

[alexander-akait]

Done in master, sorry for delay, really sorry