-
Notifications
You must be signed in to change notification settings - Fork 78
feat(libs): replace http-browserify
with stream-http
.
#41
Conversation
Have you run this updated package against webpack master? What concerns me is that this is a dep of webpack, we should probably someway verify it works in core. If we can verify that, I'm sure we can merge this. |
@TheLarkInn If it's any consolation browserify switched to Is there another test I should be running on master other than "did it get bundled"? |
Welp I think one would be npm link the dep to webpack on master, then run tests locally. I'd list that results here |
@TheLarkInn Let me know if there are reasonable tests to contribute, either to this repo or to webpack. I didn't see any tests in webpack for the builtins. |
@terinjokes I believe |
I commented on the above ticket. |
cc @jhiesey |
Getting this in would be fantastic! stream-http is much more featureful and has greater parity with the server-side version. |
Any chance of merging this in? |
Thx @terinjokes. This looks good. Could you sign the CLA? Sorry for taking so long, but switching these libraries is kind of risky because they provide an incredible big API surface to the user. Most of developers don't know this. However, since browserify is using it too, it's very safe – and it provides a consistent experience for webpack- and browserify-users. |
The PR was against node-libs-browser master which is 1.0.0. After merging this, I will try to backport most of the updates. @sokra told me, there was a breaking change in the buffer module or somewhere there, that's why he decided to release a new version but he can't remember it for sure. |
@jhnns Per the CLA, can you first add a |
- Necessary for CLA, see #41 - Without current year since it is not necessary, see facebook/react@bef45b0
Haha, good catch, thx. I added the MIT license. |
Thx @terinjokes We will probably update node-libs-browser also in webpack v1, see #45 |
|
Fixes #38.