Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chokidar to the new minor version that fixes the prototype pollution vulnerability through minmimist #148

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

mjziolko
Copy link

https://npmjs.com/advisories/1179

Chokidar 2.0.5 does not exist yet but there's a PR to cascade this fix down: paulmillr/chokidar#993

@jsf-clabot
Copy link

jsf-clabot commented Mar 18, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #148 into watchpack-1 will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           watchpack-1     #148      +/-   ##
===============================================
- Coverage        95.50%   95.22%   -0.29%     
===============================================
  Files                3        3              
  Lines              356      356              
  Branches            97       97              
===============================================
- Hits               340      339       -1     
- Misses              16       17       +1     
Impacted Files Coverage Δ
lib/DirectoryWatcher.js 95.00% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...1549c44. Read the comment docs.

@paulmillr
Copy link
Contributor

It's not chokidar 2.0.5 - it's 2.1.x

@sokra sokra closed this Mar 24, 2020
@sokra sokra reopened this Mar 24, 2020
@sokra sokra merged commit 31500fb into webpack:watchpack-1 Mar 24, 2020
@sokra
Copy link
Member

sokra commented Mar 24, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants