Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not report directory as initial missing on the second watch #227

Closed
wants to merge 1 commit into from

Conversation

WiseBird
Copy link

fixes #224

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 19, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: WiseBird / name: Sergey (200894e)

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 92.12% // Head: 77.06% // Decreases project coverage by -15.05% ⚠️

Coverage data is based on head (200894e) compared to base (dc690bb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #227       +/-   ##
===========================================
- Coverage   92.12%   77.06%   -15.06%     
===========================================
  Files           6        6               
  Lines        1041     1042        +1     
  Branches      249      250        +1     
===========================================
- Hits          959      803      -156     
- Misses         82      239      +157     
Flag Coverage Δ
integration 77.06% <100.00%> (-15.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/DirectoryWatcher.js 89.10% <100.00%> (-3.47%) ⬇️
lib/reducePlan.js 2.98% <0.00%> (-92.54%) ⬇️
lib/watchEventSource.js 46.66% <0.00%> (-39.49%) ⬇️
lib/watchpack.js 92.14% <0.00%> (-0.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WiseBird
Copy link
Author

Decreases project coverage by -15.05% ⚠️

@alexander-akait How is it possible? I added one line...

@alexander-akait
Copy link
Member

@WiseBird I think the problem on CI side, not in code

@WiseBird
Copy link
Author

WiseBird commented Jan 3, 2023

@alexander-akait What should I do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watched directory is reported as initial-missing if has no files
2 participants