Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed watch for directories containing special glob characters #52

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

omgftw
Copy link
Contributor

@omgftw omgftw commented Jun 21, 2017

Updated Chokidar
Set new chokidar "disableGlobbing" feature to "true"
Added test to prevent regression

Fixes #42
Fixes webpack/webpack#4250
Fixes angular/angular-cli#6823
Fixes aspnet/JavaScriptServices#767

@jsf-clabot
Copy link

jsf-clabot commented Jun 21, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 21, 2017

Codecov Report

Merging #52 into master will decrease coverage by 1.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage      95%   93.82%   -1.18%     
==========================================
  Files           3        3              
  Lines         340      340              
  Branches       85       85              
==========================================
- Hits          323      319       -4     
- Misses         17       21       +4
Impacted Files Coverage Δ
lib/DirectoryWatcher.js 92.85% <100%> (-1.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcdc81...689f6b4. Read the comment docs.

@ddavison
Copy link

bump. this would be nice. 👍

@TheLarkInn TheLarkInn requested a review from sokra June 25, 2017 06:39
@TheLarkInn TheLarkInn self-assigned this Jun 25, 2017
@TheLarkInn TheLarkInn self-requested a review June 25, 2017 06:39
@TheLarkInn TheLarkInn merged commit 8b37d6a into webpack:master Jul 7, 2017
@TheLarkInn
Copy link
Member

@sokra you are the only one with npm privs on this repo. Would you mind doing a publish on this when you have a chance, or let me know if you add me to npm owner list.

@TheLarkInn
Copy link
Member

TheLarkInn commented Jul 7, 2017

@omgftw Thank you so much for your first PR. 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants