cli(init): Add cachingGroup per entry, don't show name in prod

webpack · Mar 25, 2018 · 27ad714 · 27ad714
1 parent fb83ead
commit 27ad714
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 9 deletions.
diff --git a/lib/generators/init-generator.js b/lib/generators/init-generator.js
@@ -376,13 +376,39 @@ module.exports = class InitGenerator extends Generator {
 					}
 				}
 				// add splitChunks options for transparency
+				const { entry } = this.configuration.config.webpackOptions;
 				this.configuration.config.topScope.push(tooltip.splitChunks());
 				this.configuration.config.webpackOptions.optimization = {
 					splitChunks: {
-						chunks: "'all'",
-						minChunks: 1
+						chunks: "'async'",
+						minChunks: 1,
+						minSize: 30000,
 					}
 				};
+
+				// for production name is recommended to be off
+				if (this.isProd) {
+					this.configuration.config.webpackOptions.optimization.splitChunks.name = false;
+				}
+
+				if (entry && typeof entry === "object") {
+					// if user had provided multiple entry points, we make cacheGroup example
+					// per entry point
+					const entries = Object.keys(entry);
+					if (entries.length > 1) {
+						this.configuration.config.webpackOptions.optimization.splitChunks.cacheGroups = {};
+						entries.map(item => {
+							const newCacheGroup = {
+								chunks: "'all'",
+								// TODO: implement RegExp from entry for test value of caching group
+							};
+							if (!this.isProd) {
+								newCacheGroup.name = `'${item}'`;
+							}
+							this.configuration.config.webpackOptions.optimization.splitChunks.cacheGroups[item] = newCacheGroup;
+						});
+					}
+				}
 				done();
 			});
 	}

diff --git a/lib/generators/utils/entry.js b/lib/generators/utils/entry.js
@@ -36,9 +36,9 @@ module.exports = (self, answer) => {
 									if (
 										n[val].charAt(0) !== "(" &&
 										n[val].charAt(0) !== "[" &&
-										n[val].indexOf("function") < 0 &&
-										n[val].indexOf("path") < 0 &&
-										n[val].indexOf("process") < 0
+										!n[val].includes("function") &&
+										!n[val].includes("path") &&
+										!n[val].includes("process")
 									) {
 										n[val] = `"${n[val]}.js"`;
 									}
@@ -55,7 +55,7 @@ module.exports = (self, answer) => {
 					self.prompt([
 						InputValidate(
 							`${entryProp}`,
-							`What is the location of "${entryProp}"? [example: "./src/${entryProp}"]`,
+							`What is the location of "${entryProp}"? [example: './src/${entryProp}']`,
 							validate
 						)
 					])
@@ -64,9 +64,9 @@ module.exports = (self, answer) => {
 						if (
 							propAns[val].charAt(0) !== "(" &&
 							propAns[val].charAt(0) !== "[" &&
-							propAns[val].indexOf("function") < 0 &&
-							propAns[val].indexOf("path") < 0 &&
-							propAns[val].indexOf("process") < 0
+							!propAns[val].includes("function") &&
+							!propAns[val].includes("path") &&
+							!propAns[val].includes("process")
 						) {
 							propAns[val] = `"${propAns[val]}.js"`;
 						}