tests(webpack-cli): add version-external-packages-test

webpack · Apr 5, 2020 · 92434be · 92434be
1 parent afa5333
commit 92434be
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 11 deletions.
diff --git a/packages/webpack-cli/lib/groups/HelpGroup.js b/packages/webpack-cli/lib/groups/HelpGroup.js
@@ -1,5 +1,3 @@
-const path = require('path');
-const logger = require('../utils/logger');
 const chalk = require('chalk');
 const commandLineUsage = require('command-line-usage');
 
@@ -42,15 +40,11 @@ class HelpGroup {
     }
 
     outputVersion(externalPkg) {
-        if (externalPkg && externalPkg.name)
-            try {
-                const pathForExternalPkg = path.resolve(process.cwd(), 'node_modules', '@webpack-cli', externalPkg.name);
-                const ExternalPkgJson = require(pathForExternalPkg + '/package.json');
-                const { name, version } = ExternalPkgJson;
-                process.stdout.write(`\n${name} ${version}`);
-            } catch (e) {
-                logger.warn('Error external package not found.');
-            }
+        if (externalPkg && externalPkg.name) {
+            const ExternalPkgJson = require('../../../' + externalPkg.name + '/package.json');
+            const { name, version } = ExternalPkgJson;
+            process.stdout.write(`\n${name} ${version}`);
+        }
         const pkgJSON = require('../../package.json');
         const webpack = require('webpack');
         process.stdout.write(`\nwebpack-cli ${pkgJSON.version}`);

diff --git a/test/version/version-with-external-packages.test.js b/test/version/version-with-external-packages.test.js
@@ -0,0 +1,33 @@
+'use strict';
+
+const { run } = require('../utils/test-utils');
+const initPkgJSON = require('../../node_modules/@webpack-cli/init/package.json');
+const servePkgJSON = require('../../node_modules/@webpack-cli/serve/package.json');
+const migratePkgJSON = require('../../node_modules/@webpack-cli/migrate/package.json');
+const infoPkgJSON = require('../../node_modules/@webpack-cli/info/package.json');
+
+describe('version flag with external packages', () => {
+    it('outputs version with init', () => {
+        const { stdout, stderr } = run(__dirname, ['init', '--version']);
+        expect(stdout).toContain(initPkgJSON.version);
+        expect(stderr).toHaveLength(0);
+    });
+
+    it('outputs version with info', () => {
+        const { stdout, stderr } = run(__dirname, ['info', '--version']);
+        expect(stdout).toContain(infoPkgJSON.version);
+        expect(stderr).toHaveLength(0);
+    });
+
+    it('outputs version with serve', () => {
+        const { stdout, stderr } = run(__dirname, ['serve', '--version']);
+        expect(stdout).toContain(servePkgJSON.version);
+        expect(stderr).toHaveLength(0);
+    });
+
+    it('outputs version with migrate', () => {
+        const { stdout, stderr } = run(__dirname, ['migrate', '--version']);
+        expect(stdout).toContain(migratePkgJSON.version);
+        expect(stderr).toHaveLength(0);
+    });
+});