chore: rm redundant test dir cleanup, rm test level gitignore and han…

…dle at root (#1669)

* chore: remove test level gitignores, handle in root

* chore: rm redundant test dir removals

* chore: rm redundant test dir removals

Co-authored-by: James George <jamesgeorge998001@gmail.com>

.gitignore

@@ -14,7 +14,11 @@
 
 # Node dependencies
 node_modules
-!test/**/**/**/node_modules
+test/**/node_modules
+
+# Lock files
+test/**/yarn.lock
+test/**/package-json.lock
 
 # npm-debug log
 npm-debug.*
@@ -26,7 +30,6 @@ yarn-error.log
 coverage
 .nyc_output
 
-# Test Compilation
 # lerna log
 lerna-debug.log
 

test/config/multiple/all/multiple-config.test.js

@@ -1,15 +1,9 @@
 'use strict';
 const { stat } = require('fs');
-const { resolve, join } = require('path');
+const { resolve } = require('path');
 const { run } = require('../../../utils/test-utils');
-const rimraf = require('rimraf');
-
-const outputPath = join(__dirname, 'binary');
 
 describe('multiple config files', () => {
-    afterEach(() => rimraf.sync(outputPath));
-    beforeAll(() => rimraf.sync(outputPath));
-
     it('Uses prod config from dot folder if present', (done) => {
         const { stdout, stderr } = run(__dirname, [], false);
         expect(stderr).toBeFalsy();

test/config/multiple/multiple-location/multiple-location-config.test.js

@@ -1,15 +1,9 @@
 'use strict';
 const { stat } = require('fs');
-const { resolve, join } = require('path');
+const { resolve } = require('path');
 const { run } = require('../../../utils/test-utils');
-const rimraf = require('rimraf');
-
-const outputPath = join(__dirname, 'binary');
 
 describe('multiple dev config files with webpack.config.js', () => {
-    afterEach(() => rimraf.sync(outputPath));
-    beforeAll(() => rimraf.sync(outputPath));
-
     it('Uses webpack.config.development.js', (done) => {
         const { stdout, stderr } = run(__dirname, [], false);
         expect(stderr).toBeFalsy();

test/config/multiple/none and dev/dev-none-config.test.js

@@ -1,15 +1,9 @@
 'use strict';
 const { stat } = require('fs');
-const { resolve, join } = require('path');
+const { resolve } = require('path');
 const { run } = require('../../../utils/test-utils');
-const rimraf = require('rimraf');
-
-const outputPath = join(__dirname, 'binary');
 
 describe('multiple config files', () => {
-    afterEach(() => rimraf.sync(outputPath));
-    beforeAll(() => rimraf.sync(outputPath));
-
     it('Uses dev config when both dev and none are present', (done) => {
         const { stdout, stderr } = run(__dirname, [], false);
         expect(stderr).toBeFalsy();

test/config/multiple/with-mode/multiple-config.test.js

@@ -1,15 +1,9 @@
 'use strict';
 const { stat } = require('fs');
-const { resolve, join } = require('path');
+const { resolve } = require('path');
 const { run } = require('../../../utils/test-utils');
-const rimraf = require('rimraf');
-
-const outputPath = join(__dirname, 'binary');
 
 describe('multiple config files', () => {
-    afterEach(() => rimraf.sync(outputPath));
-    beforeAll(() => rimraf.sync(outputPath));
-
     it('Uses dev config when development mode is supplied', (done) => {
         const { stdout, stderr } = run(__dirname, ['--mode', 'development'], false);
         expect(stderr).toBeFalsy();

test/output/named-bundles/output-named-bundles.test.js

@@ -1,20 +1,9 @@
 'use strict';
 const { statSync } = require('fs');
-const { join, resolve } = require('path');
-const rimraf = require('rimraf');
+const { resolve } = require('path');
 const { run } = require('../../utils/test-utils');
 
 describe('output flag named bundles', () => {
-    const clean = () => {
-        rimraf.sync(join(__dirname, 'bin'));
-        rimraf.sync(join(__dirname, 'dist'));
-        rimraf.sync(join(__dirname, 'binary'));
-    };
-
-    beforeEach(clean);
-
-    afterAll(clean);
-
     it('should output file given as flag instead of in configuration', () => {
         const { stderr } = run(__dirname, ['-c', resolve(__dirname, 'webpack.config.js'), '--output', './binary/a.bundle.js'], false);
         expect(stderr).toBeFalsy();