fix: generated loader template (#1720)

* fix: generated loader template * fix: generators test * refactor: Update test/loader/loader.test.js Co-authored-by: James George <jamesgeorge998001@gmail.com> Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: James George <jamesgeorge998001@gmail.com>
webpack · Aug 2, 2020 · a380a78 · a380a78
1 parent 2f05940
commit a380a78
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/generate-loader/templates/src/_index.js.tpl b/packages/generate-loader/templates/src/_index.js.tpl
@@ -3,9 +3,9 @@
  * https://webpack.js.org/contribute/writing-a-loader
  */
 
-export default function loader(source) {
+module.exports = function loader(source) {
 	const { loaders, resource, request, version, webpack } = this;
-
+	console.log('<%= name %>');
 	const newSource = `
 	/**
 	 * <%= name %>

diff --git a/packages/generators/__tests__/loader-generator.test.ts b/packages/generators/__tests__/loader-generator.test.ts
@@ -28,7 +28,7 @@ describe('loader generator', () => {
         // Check the contents of the webpack config and loader file
         assert.fileContent([
             [join(loaderDir, 'examples/simple/webpack.config.js'), /resolveLoader: {/],
-            [join(loaderDir, 'src/index.js'), /export default function loader\(source\) {/],
+            [join(loaderDir, 'src/index.js'), /module.exports = function loader\(source\) {/],
             [join(loaderDir, 'package.json'), new RegExp(loaderName)],
         ]);
 

diff --git a/test/loader/loader.test.js b/test/loader/loader.test.js
@@ -28,7 +28,7 @@ describe('loader command', () => {
     });
 
     it('should scaffold loader template with a given name', async () => {
-        const { stdout } = await runPromptWithAnswers(__dirname, ['loader'], [`${loaderName}${ENTER}`]);
+        let { stdout } = await runPromptWithAnswers(__dirname, ['loader'], [`${loaderName}${ENTER}`]);
 
         expect(stdout).toContain(firstPrompt);
 
@@ -46,5 +46,10 @@ describe('loader command', () => {
         files.forEach((file) => {
             expect(existsSync(join(__dirname, `${loaderName}/${file}`))).toBeTruthy();
         });
+
+        //check if the the generated plugin works successfully
+        const path = resolve(__dirname, './test-loader/examples/simple/');
+        ({ stdout } = run(path, [], false));
+        expect(stdout).toContain('test-loader');
     });
 });