Skip to content

Commit

Permalink
feat(migrate): CCP to SCP - fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
dhruvdutt committed Aug 7, 2018
1 parent 6329aaa commit ebf2a98
Show file tree
Hide file tree
Showing 9 changed files with 35 additions and 38 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module.export = {
plugins: [
new webpack.optimize.CommonsChunkPlugin({
names: ["common", "vendor"],
plugins: [
new webpack.optimize.CommonsChunkPlugin({
names: ["common", "vendor"],
minChunks: 2
})
]
})
]
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.export = {
plugins: [
new webpack.optimize.CommonsChunkPlugin({
names: ["common", "vendor"]
})
]
plugins: [
new webpack.optimize.CommonsChunkPlugin({
names: ["common", "vendor"]
})
]
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.export = {
plugins: [
new webpack.optimize.CommonsChunkPlugin({
names: ["vendor"]
})
]
plugins: [
new webpack.optimize.CommonsChunkPlugin({
names: ["vendor"]
})
]
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module.export = {
plugins: [
new webpack.optimize.CommonsChunkPlugin({
plugins: [
new webpack.optimize.CommonsChunkPlugin({
filename: "commons.js",
name: "commons"
})
]
]
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
module.export = {
plugins: [
new webpack.optimize.CommonsChunkPlugin({
plugins: [
new webpack.optimize.CommonsChunkPlugin({
name: "main",
async: true,
minSize: 0,
minChunks: 2
async: true,
minSize: 0,
minChunks: 2
})
]
]
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.export = {
plugins: [
new webpack.optimize.CommonsChunkPlugin({
plugins: [
new webpack.optimize.CommonsChunkPlugin({
names: ["main", "runtime"],
})
]
]
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.export = {
plugins: [
new webpack.optimize.CommonsChunkPlugin({
plugins: [
new webpack.optimize.CommonsChunkPlugin({
name: "main",
minChunks: ({ resource }) => /node_modules/.test(resource),
minChunks: ({ resource }) => {
Expand All @@ -22,5 +22,5 @@ module.export = {
}
}
})
]
]
}
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
module.export = {
plugins: [
new webpack.optimize.CommonsChunkPlugin({
plugins: [
new webpack.optimize.CommonsChunkPlugin({
names: ["main", "vendor"],
minChunks: Infinity,
}),
// new webpack.optimize.CommonsChunkPlugin({
// name: "vendor",
// }),
]
})
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-0");
defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-1");
defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-2");
defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-3");
defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-4"); // todo fix async case
defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-4");
defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-5");
defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-6");
defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-7");

0 comments on commit ebf2a98

Please sign in to comment.