Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local fork of yeoman #161

Closed
evenstensberg opened this issue May 27, 2017 · 13 comments
Closed

Remove local fork of yeoman #161

evenstensberg opened this issue May 27, 2017 · 13 comments

Comments

@evenstensberg
Copy link
Member

Need an update from @pksjce on the bug she was complaining about recast. Moving to yeoman generators, so this needs to be resolved.

For the yeoman fork, this is removed and replaced in #148

@thescientist13
Copy link
Contributor

it appears this would address / resolve #132

@evenstensberg
Copy link
Member Author

Probably, but not entierly sure

@evenstensberg
Copy link
Member Author

This is underway at #207 , yeoman might be trickier

@evenstensberg evenstensberg changed the title Remove local forks of recast & yeoman Remove local fork of yeoman Jan 16, 2018
@mischkl
Copy link

mischkl commented Feb 27, 2018

The git dependency is causing our build to act up due to our proxy on some systems. ☹️ One more reason it would be great to get rid of the local fork dependency of yeoman as soon as possible! 😉

@evenstensberg
Copy link
Member Author

Haha yeah working on it, but need to come up with a good workaround. There's a possibility we'll need to create a temporary .yo config file for each scaffold, which shouldn't be be necessary ..

@kim-10e
Copy link

kim-10e commented Mar 5, 2018

We just ran into this issue too:

yarn install v0.27.5
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://codeload.github.com/ev1stensberg/generator/tar.gz/9e24fa31c85302ca1145ae34fc68b4f133251ca0: Request failed \"400 Bad Request\"".
info If you think this is a bug, please open a bug report with the information provided in "/Users/kimburgaard/dev/10e/release/build/enterprise-client/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

The workaround to get around this was to manually delete the yeoman-generator entry in our yarn.lock file and run yarn again.

Dependencies like these outside of the npm/yarn registries make me super uneasy for a couple of reasons. For one, npm learned the hard way to never allow publicly published packages to be deleted because it breaks dependents, and it requires more oversight to understand where all the 3rd party code comes from.

@andrewpmontgomery
Copy link

andrewpmontgomery commented Mar 6, 2018

#313 and #314 are both similar. Reverting to webpack-fork-yeoman-generator would fix the problem.

@ematipico
Copy link
Contributor

We can't at the moment because it exposes the cli to some vulnerabilities

@bponomarenko
Copy link

I have special setup where I don't have git installed in the same environment, where I have npm. Not having git prevents me from installing webpack-cli at all.

@dhruvdutt
Copy link
Member

dhruvdutt commented Mar 6, 2018

@ematipico Which vulnerabilities?
I think we were having facing issues like #291 when using the npm published fork so we reverted to using the GitHub fork in #291 which introduces proxy bugs.

@mihir478
Copy link

mihir478 commented Mar 9, 2018

@ev1stensberg I'm getting the following. I believe this is due to a corporate firewall issue but could also be a proxy issue. Any ideas?

λ yarn add webpack-cli -D
yarn add v1.5.1
[1/4] Resolving packages...
warning webpack-cli > jscodeshift > babel-preset-es2015@6.24.1: � Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
warning webpack-cli > jscodeshift > nomnom@1.8.1: Package no longer supported. Contact support@npmjs.com for more info.
error An unexpected error occurred: "https://raw.githubusercontent.com/ev1stensberg/generator/9e24fa31c85302ca1145ae34fc68b4f133251ca0/package.json: unable to get local issuer certificate".
info If you think this is a bug, please open a bug report with the information provided in ...

@dhruvdutt
Copy link
Member

@mihir478 We've identified this error and the fix should out soon. You can track it at #323.
Thanks for reporting.

@evenstensberg
Copy link
Member Author

webpack-cli@2.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants