Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many devDependencies listed as dependencies #306

Closed
billyjanitsch opened this issue Mar 3, 2018 · 3 comments · Fixed by #309
Closed

Many devDependencies listed as dependencies #306

billyjanitsch opened this issue Mar 3, 2018 · 3 comments · Fixed by #309

Comments

@billyjanitsch
Copy link
Member

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Many devDependencies of this project are listed as dependencies in package.json such as prettier and codecov. This causes them to be installed when a user installs webpack-cli.

There are also some dependencies that don't appear to be used at all, such as global.

If a dependency isn't needed at runtime, it shouldn't be listed in dependencies.

What is the expected behavior?

Only the dependencies necessary to run webpack-cli are installed alongside it.

If this is a feature request, what is motivation or use case for changing the behavior?

webpack-cli is currently a huge install (~66mb). It would be nice to cut down on the dependencies it requires, especially since this project is now required to interact with webpack via CLI.

@olore
Copy link

olore commented Mar 5, 2018

Relatedly (?) the inclusion of the following is erroring on my build servers because of proxy issues and what not.

 "yeoman-generator": "github:ev1stensberg/generator#Feature-getArgument"

Is there a plan to get this into a published npm package soon? Can I help? /ping @ev1stensberg

@ematipico
Copy link
Contributor

ematipico commented Mar 6, 2018

About the local fork, we have an open issue here #161, we are looking for the best solution.

About the dependencies, it would be nice to have a PR. It shouldn't be too difficult. Help is appreciated!

@olore
Copy link

olore commented Mar 6, 2018

Thanks @ematipico. Not sure how I missed that one.

Looks like there is already a PR for the dependencies from @billyjanitsch #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants