feat(webpack-cli): add mode argument validation #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
jamesgeorge007
requested changes
Mar 4, 2020
snitin315
force-pushed
the
feat/mode-validation
branch
from
dd9840a to
125096a
Compare
ematipico
reviewed
Mar 4, 2020
snitin315
force-pushed
the
feat/mode-validation
branch
from
125096a to
9776d8b
Compare
ematipico
suggested changes
Mar 4, 2020
snitin315
force-pushed
the
feat/mode-validation
branch
from
9776d8b to
e56b3dc
Compare
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
ematipico
reviewed
Mar 4, 2020
snitin315
force-pushed
the
feat/mode-validation
branch
2 times, most recently
from
6df4c94 to
430c6ff
Compare
snitin315
force-pushed
the
feat/mode-validation
branch
from
430c6ff to
cb4e43d
Compare
|
I think we should add the test case for invalid value , as now we are returning @ematipico what do you say? |
|
Yes of course. |
|
@snitin315 I fixed the failing tests. Would you please rebase your PR? |
snitin315
force-pushed
the
feat/mode-validation
branch
from
cb4e43d to
9a8b9f5
Compare
|
@ematipico Done 💯 |
snitin315
force-pushed
the
feat/mode-validation
branch
from
9a8b9f5 to
1827671
Compare
snitin315
force-pushed
the
feat/mode-validation
branch
from
1827671 to
fc4fae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #1282
Refers #1261
Did you add tests for your changes?
Yes.
If relevant, did you update the documentation?
Yes
Summary
Added validation for
modeargument , now can only acceptdevelopment , production or nonewill promt a warning if set to any other value.
Does this PR introduce a breaking change?
NO.