chore(webpack-cli): remove pretty output functionality #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ class StatsGroup extends GroupHelper { | |||
|
|
|||
| resolveOptions() { | |||
| if (this.args.verbose && this.args.stats) { | |||
| logger.warn('Conflict between "verbose" and "stats" options. Using verbose.'); | |||
| logger.warn('Conflict between "verbqose" and "stats" options. Using verbose.'); | |||
ematipico
force-pushed
the
feature/remove-pretty-output
branch
from
ca35fe3
to
238b401
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
alexander-akait
approved these changes
Mar 12, 2020
anshumanv
approved these changes
Mar 12, 2020
snitin315
approved these changes
Mar 12, 2020
jamesgeorge007
approved these changes
Mar 13, 2020
wizardofhogwarts
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I kind of breaking change but it's needed for webpack ecosystem.
Did you add tests for your changes?
I removed the tests that are not needed
If relevant, did you update the documentation?
Yes
Summary
This PR removes
--prettyargument and all the code behind it. Also, it removescli-table3which is not maintained anymore (it still runs on node 6 and there are no updates on future releases).Does this PR introduce a breaking change?
It could, but I don't the
--prettyargument was used so much. An alternative will be available inside webpack coreOther information