Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create initial CHANGELOG.md file #133

Merged
merged 2 commits into from
May 14, 2017

Conversation

avivr
Copy link
Contributor

@avivr avivr commented May 10, 2017

Add CHANGELOG.md file.
Generated using cz-conventional-changelog cli tool.

This address issue #130

@jsf-clabot
Copy link

jsf-clabot commented May 10, 2017

CLA assistant check
All committers have signed the CLA.

@evenstensberg
Copy link
Member

@avivr Hey! Thanks for the PR! I think we can simplify this a lot for the first changelog. What do you say @okonet ?

@evenstensberg
Copy link
Member

Hey Aviv! I'd suggest you just to put up a blank one for us to fill. Found a default one at webpack-defaults. Thanks!


Change Log

All notable changes to this project will be documented in this file. See standard-version for commit guidelines.

x.x.x / --

  • Bug fix -
  • Feature -
  • Chore -
  • Docs -

@avivr
Copy link
Contributor Author

avivr commented May 13, 2017

thanks for the feedback @ev1stensberg , i wasn't aware of webpack-defaults.
I changed it to match the CHANGELOG from the templates folder, hope that's what you meant.

@evenstensberg
Copy link
Member

Yup! I'll push some changes to this branch later, and I'll merge :)

@evenstensberg evenstensberg changed the base branch from master to update-changelog May 14, 2017 15:37
@evenstensberg evenstensberg merged commit 9fc534c into webpack:update-changelog May 14, 2017
@evenstensberg
Copy link
Member

Hmm, seems like you didn't join the collab list. Sorry about that @avivr .. Could you make a new PR for v.1.3.1 using https://github.com/conventional-changelog/standard-version ? Seems like they generated the same changelog as in the initial PR, but I cut some commits that weren't needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants