Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stats detailed option #1359

Merged
merged 3 commits into from
Mar 24, 2020
Merged

feat: add stats detailed option #1359

merged 3 commits into from
Mar 24, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
added stats detailed option which was unrecognized.

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Yes

Summary

  • Added detailed stats option which we missed.

Does this PR introduce a breaking change?
No

Other information
NA

@anshumanv anshumanv requested a review from a team as a code owner March 21, 2020 16:18
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

rishabh3112
rishabh3112 requested changes Mar 24, 2020
View reviewed changes
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stats don't include detailed officially, and I can't find it in webpack v5 too. Sharing a supporting reference for it would be great.
For reference: https://webpack.js.org/configuration/stats/#stats

@anshumanv
Copy link
Member Author

@rishabh3112 here - https://github.com/webpack/webpack/blob/f0b1a71d5a4ba7a685e76d08281195364d7dd9b3/lib/stats/DefaultStatsPresetPlugin.js#L47

Probably it needs to be documented too, I'll open an issue in the docs?

alexander-akait
alexander-akait requested changes Mar 24, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good one note

@rishabh3112
Copy link
Member

rishabh3112 commented Mar 24, 2020 •
edited
Loading

Thanks for insight @anshumanv. It is good now :)

@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

@anshumanv
Copy link
Member Author

@evilebottnawi @rishabh3112, should be good now. :)

alexander-akait
alexander-akait approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team need more reviews

@anshumanv anshumanv merged commit 3e649e9 into webpack:next Mar 24, 2020
@anshumanv anshumanv deleted the fix/stats branch March 24, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anshumanv @webpack-bot @rishabh3112 @alexander-akait @jamesgeorge007 @snitin315