Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webpack-cli): remove --no-mode flag #1503

Merged
merged 1 commit into from
Apr 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/webpack-cli/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ Options
-d, --dev Run development build
-p, --prod Run production build
--mode string Defines the mode to pass to webpack
--no-mode Sets mode="none" which disables any default behavior
-v, --version Get current version
--node-args string[] NodeJS flags
--stats type It instructs webpack on how to treat the stats
Expand Down
15 changes: 3 additions & 12 deletions packages/webpack-cli/lib/groups/ZeroConfigGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,12 @@ class ZeroConfigGroup extends GroupHelper {
if (process.env.NODE_ENV && (process.env.NODE_ENV === PRODUCTION || process.env.NODE_ENV === DEVELOPMENT)) {
return process.env.NODE_ENV;
} else {
// commander sets mode to false if --no-mode is specified
const noMode = this.args.mode === false;
if ((this.args.mode || noMode) && (this.args.dev || this.args.prod)) {
if (this.args.mode && (this.args.dev || this.args.prod)) {
logger.warn(
`You provided both ${this.args.mode ? 'mode' : 'no-mode'} and ${
`You provided both 'mode' and ${
this.args.prod ? '--prod' : '--dev'
} arguments. You should provide just one. "${this.args.mode ? 'mode' : 'no-mode'}" will be used`,
} arguments. You should provide just one. "mode" will be used`,
);
if (this.args.mode) {
return this.args.mode;
} else {
return NONE;
}
}

if (this.args.mode) {
Expand All @@ -46,8 +39,6 @@ class ZeroConfigGroup extends GroupHelper {
return PRODUCTION;
} else if (this.args.dev) {
return DEVELOPMENT;
} else if (noMode) {
return NONE;
}
return PRODUCTION;
}
Expand Down
8 changes: 0 additions & 8 deletions packages/webpack-cli/lib/utils/cli-flags.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,6 @@ module.exports = {
description: 'Defines the mode to pass to webpack',
link: 'https://webpack.js.org/concepts/#mode',
},
{
name: 'no-mode',
usage: '--no-mode',
type: Boolean,
group: ZERO_CONFIG_GROUP,
description: 'Sets mode="none" which disables any default behavior',
link: 'https://webpack.js.org/concepts/#mode',
},
{
name: 'version',
usage: '--version | --version <external-package>',
Expand Down
70 changes: 0 additions & 70 deletions test/no-mode/no-mode.test.js

This file was deleted.

1 change: 0 additions & 1 deletion test/no-mode/src/index.js

This file was deleted.