feat: replace yarn backup w/ normal yarn #160
Conversation
|
Why did we disable this in the first place? I know there was a yarn issue with recast but has that been resolved? |
|
Actually this is a question that I wanted to ask you, are we using npm or yarn? After installing again the project, I got the next unstaged files, which confuses me a bit: Maybe we should consider using only one? |
|
Why is that better over both? Users use both |
|
Sorry for my late reply. As for this project, one could argue, to have both installed, and maintain both. Which would be ok, not a biggie. However, as maintainers we need to put some (small but still present) extra effort on keeping them both up to date. I've been there at the beginning of the project, and was probably me the one who added yarn to the project at the first place. But, after having got a long break on the cli, and having come back, the first thing I did was to install all the dependencies. And to be honest, I really did not get what should I use to do so, yarn or npm?. I read the contributing.md (that I wrote) and still was not clear. After having got a new fresh look into this, I'd recommend that we just make this easier for us, and keep only one. Yes, it is true that users use yarn, or npm, but that is not really a strong argument to keep both in the project. If both do the same, what is the benefit for us of having two libraries doing the same thing, which in this case, increase maintenance effort and/or confusion at the entry of new devs/coming back devs? |
|
When I started my devs on the cli I was confused as well and when I saw the .yarn file (even though it was a backup file) I guessed I had to use yarn at first place. Although I was confused. 😄 |
|
Yeah, it's quite confusing. Since webpack main repo doesn't use yarn I'd say let's stick with npm for the consistency sake. This is what I would do:
Thoughts? |
|
Users are complaining that we aren't supporting yarn though? |
|
@okonet I added already .2 of your list in #173, I could add in there also the .1 and .3, and update the contributing.d @ev1stensberg do you know the reasons why the users complain about it? and from which medium are they complaining? with more info about it we could make a more informed decision. |
|
@ev1stensberg what users? This is only relevant for contributors. |
|
Actually, webpack uses yarn instead of npm |
evenstensberg
force-pushed
the
replace-yarn
branch
from
c319f45 to
bbda6df
Compare
* feat: replace yarn backup w/ normal yarn * upgrade npm & remove yarn
* chore: Use prettier (#173) * build: Add webpack lint settings and style code with eslint --fix We now use the webpack eslint settings that make sense in the cli. Also use the new --fix of eslint to automatically beautify the code * Add additional .eslintrc to /bin to remove unrelated eslint errors * build: Add jest-cli as dev dependency * style: fix lintin errors and coding style according to webpack settings * build: update dependencies and add package-lock to repo * feat: Require quotes only in property names that require it * chore: Add again removed settings by merge conflict solving * tests: Fix failing test * chore: Use husky instead of pre-commit pre-commit package stopped working. See observing/pre-commit#113 husky also requires less boilerplate in the package.json * [Feature] Added support to Flow inside transformations (#174) * [FLOW] Implemented interfaces and flow types inside the transformations * [FLOW] first commit * Added flwo to two other files * Reviewed interfaces * Created different intefaces for expressions * Fixed rest of trasformations * More developments * Updated code after code review * Fixed failing tests * Removed yarn file * Applied linting * Updated packages * Applied lint style to the imports due to code review * docs: Documentation for migrate (#175) * initial draft of migrate documentation * formatting * formatting * added summary of migrate changes * maintain consistent usage of user through documentation * Feature/generate loader (#183) * Add template files for loader yeoman generator * Create yeoman generator for a webpack loader project * Add tests for loader-generator * Add `mkdirp` dependency for loader-generator * Add function to create yeoman env and run loader-generator * Add `generate-loader` command to webpack-cli * Copy loader templates from proper directory * Add template files for plugin generator * Create yeoman generator for webpack plugins * Add function to create yeoman env and run plugin generator * Add cli command to generate plugin * Register generate- commands in yargs * Add template files for loader examples and tests * Copy loader test and example template files in generator * Add template files for plugin examples and tests * Copy plugin test and example template files in generator * Refactor generator file copying, switch .includes with .indexOf in CLI arg parsing * Change `indexOf('foo') > -1` to `indexOf('foo') >= 0` * Factor out generator copy utilities into separate module * Rewrite generators using a function that returns a customized generator class * Fix linting errors * Remove //eslint-disable lines from template files * Add unit tests for CLI and add flow compilation (#186) * add unit tests for everything and flow compilation * add travis builds * add cli to signature & add ignore to trash code * port to jest * remove redundant cli command * Feature/generate loader (#183) * Add template files for loader yeoman generator * Create yeoman generator for a webpack loader project * Add tests for loader-generator * Add `mkdirp` dependency for loader-generator * Add function to create yeoman env and run loader-generator * Add `generate-loader` command to webpack-cli * Copy loader templates from proper directory * Add template files for plugin generator * Create yeoman generator for webpack plugins * Add function to create yeoman env and run plugin generator * Add cli command to generate plugin * Register generate- commands in yargs * Add template files for loader examples and tests * Copy loader test and example template files in generator * Add template files for plugin examples and tests * Copy plugin test and example template files in generator * Refactor generator file copying, switch .includes with .indexOf in CLI arg parsing * Change `indexOf('foo') > -1` to `indexOf('foo') >= 0` * Factor out generator copy utilities into separate module * Rewrite generators using a function that returns a customized generator class * Fix linting errors * Remove //eslint-disable lines from template files * add unit tests for everything and flow compilation * add travis builds * add cli to signature & add ignore to trash code * port to jest * remove redundant cli command * rebase against master * ast for devServer (#185) * feat: replace yarn backup w/ normal yarn (#160) * feat: replace yarn backup w/ normal yarn * upgrade npm & remove yarn * Use yarn if available (#189) * bump version to 1.3.4 * update package.json * 1.3.5 * prepublish -> postinstall * 1.3.6 * temp fix to prepublish issue * 1.3.7 * add propper post install * 1.3.8 * re-add manual build step * 1.3.9 * refactor * bump version * disable published pkg * add ignore patterns * add more ignore patterns for npm
CC-ing @pksjce