Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant instructions #1671

Merged
merged 1 commit into from
Jul 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/cleanupTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const rimraf = require('rimraf');
const { join } = require('path');
const collectTestFolders = require('./utils');

const outputDirectories = ['bin', 'binary', 'dist'];
const outputDirectories = ['bin', 'binary', 'dist', 'test-assets', 'test-plugin', 'test-loader'];

function folderStrategy(stats, file) {
return stats.isDirectory() && outputDirectories.includes(file);
Expand Down
4 changes: 0 additions & 4 deletions test/init/auto/init-auto.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ describe('init auto flag', () => {
fs.mkdirSync(genPath);
});

afterAll(() => {
rimraf.sync(genPath);
});

it('should prompt with w/o auto flag', () => {
const { stdout, stderr } = run(genPath, ['init'], false);
expect(stdout).toBeTruthy();
Expand Down
4 changes: 0 additions & 4 deletions test/init/force/init-force.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ describe('init force flag', () => {
fs.mkdirSync(genPath);
});

afterAll(() => {
rimraf.sync(genPath);
});

it('should scaffold webpack config', async () => {
const { stdout } = await runPromptWithAnswers(genPath, ['init', '--force'], [`N${ENTER}`, ENTER, ENTER, ENTER, ENTER, ENTER]);

Expand Down
4 changes: 0 additions & 4 deletions test/init/generator/init-inquirer.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ describe('init', () => {
fs.mkdirSync(genPath);
});

afterAll(() => {
rimraf.sync(genPath);
});

it('should scaffold when given answers', async () => {
const { stdout } = await runPromptWithAnswers(genPath, ['init'], [`N${ENTER}`, ENTER, ENTER, ENTER, ENTER, ENTER]);

Expand Down
4 changes: 0 additions & 4 deletions test/init/language/css/init-language-css.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ describe('init with SCSS', () => {
fs.mkdirSync(genPath);
});

afterAll(() => {
rimraf.sync(genPath);
});

it('should use SCSS', async () => {
const { stdout } = await runPromptWithAnswers(
genPath,
Expand Down
4 changes: 0 additions & 4 deletions test/init/language/js/init-language-js.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ describe('init with Typescript', () => {
fs.mkdirSync(genPath);
});

afterAll(() => {
rimraf.sync(genPath);
});

it('should use typescript', async () => {
const { stdout } = await runPromptWithAnswers(genPath, ['init'], [`N${ENTER}`, ENTER, ENTER, `${DOWN}${DOWN}${ENTER}`, ENTER]);

Expand Down
4 changes: 0 additions & 4 deletions test/init/multipleEntries/init-multipleEntries.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ describe('init with multiple entries', () => {
fs.mkdirSync(genPath);
});

afterAll(() => {
rimraf.sync(genPath);
});

it('should scaffold with multiple entries', async () => {
const { stdout } = await runPromptWithAnswers(
genPath,
Expand Down
4 changes: 0 additions & 4 deletions test/loader/loader.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ describe('loader command', () => {
rimraf.sync(loaderPath);
});

afterAll(() => {
rimraf.sync(loaderPath);
});

it('Should ask the loader name when invoked', () => {
const { stdout, stderr } = run(__dirname, ['loader'], false);
expect(stdout).toBeTruthy();
Expand Down
4 changes: 0 additions & 4 deletions test/migrate/config/migrate-config.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ describe('migrate command', () => {
fs.mkdirSync(outputPath);
});

afterAll(() => {
rimraf.sync(outputPath);
});

it('should warn if the source config file is not specified', () => {
const { stderr } = run(__dirname, ['migrate'], false);
expect(stderr).toContain('Please specify a path to your webpack config');
Expand Down
4 changes: 0 additions & 4 deletions test/plugin/plugin.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ describe('plugin command', () => {
rimraf.sync(pluginPath);
});

afterAll(() => {
rimraf.sync(pluginPath);
});

it('Should ask the plugin name when invoked', () => {
const { stdout, stderr } = run(__dirname, ['plugin'], false);
expect(stdout).toBeTruthy();
Expand Down