feat: add support for .cjs config #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +42,16 @@ const getDefaultConfigFiles = () => { | |||
|
|
|||
| const getConfigInfoFromFileName = (filename) => { | |||
| const fileMetaData = parse(filename); | |||
| // .cjs is not available on interpret side, handle it manually for now | |||
There was a problem hiding this comment.
@evilebottnawi check https://github.com/gulpjs/interpret/blob/57cd5973c313c420b1ad24a922d1c95ebec3c532/index.js#L181 doesn't have .cjs hence need manual handling
alexander-akait
approved these changes
Aug 3, 2020
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
snitin315
approved these changes
Aug 5, 2020
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not yet
Summary
Does this PR introduce a breaking change?
No
Other information