Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: regenerate lock file #1731

Closed
wants to merge 1 commit into from
Closed

chore: regenerate lock file #1731

wants to merge 1 commit into from

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented Aug 4, 2020

What kind of change does this PR introduce?

chore

Did you add tests for your changes?
No

If relevant, did you update the documentation?
NA

Summary
regenerated lock file to test in CI

Does this PR introduce a breaking change?
No

Other information

@anshumanv
Copy link
Member Author

ts build is failing lemme see

@alexander-akait
Copy link
Member

Yes, cache on register side 😞

@alexander-akait
Copy link
Member

Let's add workaround for CI for webpack@5, yarn add terser-webpack-plugin --dev (only for webpack@5)

@anshumanv
Copy link
Member Author

okay will do

@anshumanv
Copy link
Member Author

Added here - #1732

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase?

@anshumanv
Copy link
Member Author

yep in near future

@anshumanv
Copy link
Member Author

Closed in favour of #1885

@anshumanv anshumanv deleted the lock branch October 7, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants