-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update generator deps #1758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is break yarn PnP
Would adding |
I think we can solve it using steps:
|
we don't, we just use
|
I mean this packages unnecessary, because we always install then, no need to keep them in deps |
Yes, these packages are unnecessary. As this would take long time to refactor it, I thought of doing this so that we can release within this week. Rest, I also support removing these packages. |
Closing as full refactor is in progress at #1822 |
What kind of change does this PR introduce?
chore, avoid duplication of package utils (Just for release)
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
Summary
Before:
After:
Does this PR introduce a breaking change?
No
Other information
Not an intended solution. Follow #1752 for it.