-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show warning if bail and watch are used together #1804
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
53bb5a7
fix: show warning if bail and watch are used together
snitin315 20b246c
fix: watch
snitin315 c43b93b
tests: update
snitin315 685df00
chore: add comments
snitin315 f8f0035
Merge branch 'next' into fix/bail-watch-warn
jamesgeorge007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
packages/webpack-cli/lib/utils/warnings/bailAndWatchWarning.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
const logger = require('../logger'); | ||
|
||
/** | ||
* warn the user if bail and watch both are used together | ||
* @param {Object} webpack compiler | ||
* @returns {void} | ||
*/ | ||
const bailAndWatchWarning = (compiler) => { | ||
if (compiler.options.bail && compiler.options.watch) { | ||
logger.warn('You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.'); | ||
} | ||
}; | ||
|
||
module.exports = bailAndWatchWarning; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
'use strict'; | ||
|
||
const { run } = require('../utils/test-utils'); | ||
|
||
describe('bail and watch warning', () => { | ||
it('should log warning in case of single compiler', () => { | ||
const { stderr, stdout } = run(__dirname, ['-c', 'single-webpack.config.js']); | ||
|
||
expect(stderr).toContain(`You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.`); | ||
expect(stdout).toBeTruthy(); | ||
}); | ||
|
||
it('should log warning in case of multiple compilers', () => { | ||
const { stderr, stdout } = run(__dirname, ['-c', 'multi-webpack.config.js']); | ||
|
||
expect(stderr).toContain(`You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.`); | ||
expect(stdout).toBeTruthy(); | ||
}); | ||
|
||
it('should log not log warning if both are not true', () => { | ||
const { stderr, stdout } = run(__dirname, ['-c', 'third-webpack.config.js']); | ||
|
||
expect(stderr).not.toContain(`You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.`); | ||
expect(stdout).toBeTruthy(); | ||
}); | ||
}); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
module.exports = [ | ||
{ | ||
output: { | ||
filename: './dist-first.js', | ||
}, | ||
name: 'first', | ||
entry: './src/first.js', | ||
mode: 'development', | ||
}, | ||
{ | ||
output: { | ||
filename: './dist-second.js', | ||
}, | ||
name: 'second', | ||
entry: './src/second.js', | ||
mode: 'production', | ||
bail: true, | ||
watch: true, | ||
}, | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
entry: './src/first.js', | ||
mode: 'development', | ||
bail: true, | ||
watch: true, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
console.log('bail and watch warning test first'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
console.log('bail and watch warning test second'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
module.exports = { | ||
entry: './src/first.js', | ||
mode: 'development', | ||
bail: true, | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests where
bail: false
andwatch: true
/watch: false
andbail: true
and check there is not warnings/errors?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added