chore: remove lodash from direct dependencies #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Sep 25, 2020
evenstensberg
approved these changes
Sep 25, 2020
anshumanv
reviewed
Sep 25, 2020
anshumanv
approved these changes
Sep 25, 2020
snitin315
approved these changes
Sep 25, 2020
I have removed lodash where ever it was direct dep. Still many versions of lodash are shipped as transitive dep as mentioned by @anshumanv in his review as well. |
|
Feel free to merge after green |
We should remove version locking in packages, maybe that will reduce some |
|
Will try to do it this weekend, or if anyone else wants to feel free and let me know |
Where we have it? |
|
@webpack/cli-team please focus on use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Remove lodash from dependencies to reduce deps
Does this PR introduce a breaking change?
No
Other information
As per feedback for v4