refactor: CLI creator class #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: cleanup cli chore: rm unused code
alexander-akait
approved these changes
Nov 2, 2020
anshumanv
changed the title
snitin315
approved these changes
Nov 2, 2020
| acc[toKebabCase(cur)] = parsedArgs[cur]; | ||
| return acc; | ||
| }, {}); | ||
| const coreCliHelper = require('webpack').cli; |
There was a problem hiding this comment.
What about if we have webpack@4? We don't have .cli
There was a problem hiding this comment.
oops, I think it worked, lemme recheck
There was a problem hiding this comment.
Yep, let's check it, but ci success so I think it should be work
There was a problem hiding this comment.
strange, passed in CI but fails locally 😞
There was a problem hiding this comment.
sending a follow up - sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information
Fixes #1877