-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: suggest the closest match based on the Levenshtein distance algorithm #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
force-pushed
the
feat/suggest-flags
branch
2 times, most recently
from
November 1, 2020 07:22
fd8fef0
to
2f72e8e
Compare
snitin315
reviewed
Nov 1, 2020
snitin315
reviewed
Nov 1, 2020
jamesgeorge007
force-pushed
the
feat/suggest-flags
branch
from
November 2, 2020 08:41
2f72e8e
to
b8d480f
Compare
snitin315
previously approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jamesgeorge007
force-pushed
the
feat/suggest-flags
branch
from
November 2, 2020 12:09
dfb5ba2
to
a8b91c3
Compare
alexander-akait
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
snitin315
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yup
If relevant, did you update the documentation?
N/A
Summary
Refers #1261
Suggest the closest match for an unknown flag.
Does this PR introduce a breaking change?
Nope
Other information
N/A