Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suggest the closest match based on the Levenshtein distance algorithm #2010

Merged
merged 3 commits into from
Nov 2, 2020

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yup

If relevant, did you update the documentation?
N/A

Summary
Refers #1261
Suggest the closest match for an unknown flag.

Does this PR introduce a breaking change?
Nope

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner November 1, 2020 06:47
@jamesgeorge007 jamesgeorge007 force-pushed the feat/suggest-flags branch 2 times, most recently from fd8fef0 to 2f72e8e Compare November 1, 2020 07:22
snitin315
snitin315 previously approved these changes Nov 2, 2020
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@jamesgeorge007 jamesgeorge007 merged commit 491a582 into master Nov 2, 2020
@jamesgeorge007 jamesgeorge007 deleted the feat/suggest-flags branch November 2, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants