-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for readability (v2 branch) #214
Conversation
I'll fix the conflicts, thank you so much @kingdaro ! |
Oh, wait, correct. Made some modifications to the add generator. Could you do that too? For the remove and update generator, just resolve the conflicts by setting it to your commit |
Resolving conflicts, and in update-generator and remove-generator, the linter is complaining about something being used called |
|
Just to be 100% certain, here's the contents of the file: https://gist.github.com/kingdaro/f298dc8b7abf7ec8589ab6b23405e588 So the bottom bit is what's coming from |
yep, that's correct |
c894c2a
to
19894f2
Compare
Done @kingdaro ? No changes to |
84f82f2
to
2e76338
Compare
Yeah, that was a mistake, fixed now. Should be good to go 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!!!
No description provided.