Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(defaults): remove entry and output.path validation #217

Merged
merged 4 commits into from
Dec 16, 2017

Conversation

TheLarkInn
Copy link
Member

@TheLarkInn TheLarkInn commented Dec 16, 2017

What kind of change does this PR introduce?

Feature
Did you add tests for your changes?
N/A(?)
If relevant, did you update the documentation?
Does it need to be documented? (We can discuss).

Summary
This PR is a dependent PR for webpack/webpack#6140. The aforementioned PR removes validation tests in favor of sensible defaults.

Turns out removing them exposes outdated entry and output.path validations that lived in the cli at one time. This PR removes those validations.

Does this PR introduce a breaking change?

Other information
Also bumping optional dependency version for webpack to alpha.1

@TheLarkInn TheLarkInn changed the base branch from master to v2 December 16, 2017 05:43
package.json Outdated
@@ -86,7 +86,7 @@
},
"optionalDependencies": {
"schema-utils": "^0.4.2",
"webpack": "^4.0.0-alpha.0",
"webpack": "^4.0.0-alpha.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma :)

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: , thanks! FWIW, if webpack can't find the entry or src code, the validationschema is gonna throw, at least from testing this in the v2 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants