[Feature] webpack-bot integration for webpack-cli #220
Conversation
ematipico
changed the title
ematipico
changed the title
|
Hey @ematipico , awesome! Any way to test this without merging? I.e make it comment some stuff? |
|
I don't know honestly. It's possible to test locally but when you create a new bot. Here we are adding configuration for a bot that already exists and already works. Maybe @sokra can help us |
open-bot.yml
Outdated
| ensure_1: | ||
| value: "{{status_1.state}}" | ||
| equals: "failure" | ||
| not: |
There was a problem hiding this comment.
You could omit this not: section, as there is no other CI provider
open-bot.yml
Outdated
| {{{logResult}}} | ||
| ``` | ||
|
|
||
| Instead of updating these (outdated?) unit tests, you can choose to delete them and add integration tests instead. That would be great. |
There was a problem hiding this comment.
This is probably not relevant here
package.json
Outdated
| @@ -23,7 +23,9 @@ | |||
| "precommit": "lint-staged", | |||
| "prepublish": "flow-remove-types lib/ -d dist/ && npm run format:dist", | |||
| "pretest": "npm run lint", | |||
| "test": "jest --coverage" | |||
| "test": "jest --coverage", | |||
| "travis:unit": "npm run test", | |||
There was a problem hiding this comment.
travis:unit -> travis:test as this includes integration and unit test
package.json
Outdated
| "test": "jest --coverage" | ||
| "test": "jest --coverage", | ||
| "travis:unit": "npm run test", | ||
| "travis:lint": "npm run lint" |
There was a problem hiding this comment.
You need to adapt .travis.yml too
open-bot.yml
Outdated
| message: |- | ||
| @{{commit.author.login}} The most important CI builds failed. This way your PR can't be merged. | ||
|
|
||
| Please take a look at the CI results from [travis]({{status_1.target_url}}) ({{status_1.state}}) and [appveyor]({{status_2.target_url}}) ({{status_2.state}}) and fix these issues. |
There was a problem hiding this comment.
status_2 is not defined and not needed as there is only one CI provider.
Added new dist command to generate a clean distribution folder
|
@sokra PR updated with the requested changes |
| - npm run prepublish | ||
| - npm run lint | ||
| - npm run test | ||
| script: npm run travis:$JOB_PART |
There was a problem hiding this comment.
I updated the file based on what we already have inside the webpack/webpack repository. I hope we are on the right path
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Fixes #195
Does this PR introduce a breaking change?
No
Other information
The configuration is copied from
webpackrepository and adapted to the current repository. The actions that the bot will do are:CI-okandCI-not-okto the PRs (labels needed)PR: conflict(labels needed)unreviewed,reviewedandreview-outdatedto the PRs (labels needed)PR: smallif the PR contains small changes (label needed)I also added two new npm scripts that will be used just by the bot.