reduce coupling between webpack and webpack-cli #229
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
existing tests
If relevant, did you update the documentation?
N/A
Summary
require("webpack/lib/DefinePlugin")
->require("webpack").DefinePlugin
Does this PR introduce a breaking change?
yes, since
webpack.Stats
is not exposed by webpack versions <= 4.0.0-alpha.2, this change will only work with higher versions. It was exposed by webpack/webpack@289ba67Other information
The goal is to reduce the coupling between webpack and webpack-cli.
webpack-cli should only use the public webpack API.