Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test for missing packages #2296

Merged
merged 25 commits into from
Jan 9, 2021
Merged

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
feature/ tests

Did you add tests for your changes?
yes

If relevant, did you update the documentation?
N/A

Summary
Currently we were not test missing package case, should increase coverage there

Does this PR introduce a breaking change?
No

Other information
No

@rishabh3112 rishabh3112 requested a review from a team as a code owner January 2, 2021 06:53
@rishabh3112 rishabh3112 marked this pull request as draft January 2, 2021 07:21
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #2296 (023fac2) into master (b6884fa) will not change coverage.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2296   +/-   ##
=======================================
  Coverage   68.10%   68.10%           
=======================================
  Files          52       52           
  Lines        2060     2060           
  Branches      507      507           
=======================================
  Hits         1403     1403           
  Misses        657      657           
Impacted Files Coverage Δ
packages/generators/addon-template/package.json.js 100.00% <ø> (ø)
packages/generators/init-template/package.json.js 100.00% <ø> (ø)
packages/generators/init-template/tsconfig.json.js 100.00% <ø> (ø)
packages/generators/src/types/index.ts 100.00% <ø> (ø)
packages/generators/src/init-generator.ts 90.00% <83.33%> (ø)
packages/configtest/src/index.ts 94.73% <100.00%> (ø)
packages/generators/src/addon-generator.ts 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7506f07...023fac2. Read the comment docs.

@rishabh3112 rishabh3112 marked this pull request as ready for review January 8, 2021 10:42
@alexander-akait
Copy link
Member

@rishabh3112 Can you rebase?

@rishabh3112
Copy link
Member Author

Sure, will do tomorrow.

@alexander-akait
Copy link
Member

@rishabh3112 Can you rebase?

@rishabh3112
Copy link
Member Author

Done @alexander-akait

@alexander-akait
Copy link
Member

Good job!

@alexander-akait alexander-akait merged commit ff2b2b3 into master Jan 9, 2021
@alexander-akait alexander-akait deleted the feat/no-package-tests branch January 9, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants