-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate migrate package #2313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2313 +/- ##
==========================================
+ Coverage 67.48% 68.05% +0.57%
==========================================
Files 64 52 -12
Lines 2519 2060 -459
Branches 589 508 -81
==========================================
- Hits 1700 1402 -298
+ Misses 819 658 -161
Continue to review full report at Codecov.
|
I think we should update it for |
We don't have time and enough developers to do it, so I prefer not lose time on this |
And most of migrations are impossible to do due a lot of different cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main idea - webpack migrate
still will work for current version, but we remove this package from our code and will not update anymore
wip fixing conflicts |
@alexander-akait fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One fix and we can merge, I think we should remove this command from CLI docs page https://webpack.js.org/api/cli/, because now it is not rerecorded to use and deprecated
will make a PR on docs after release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge when CI will be green
And let's fix conflict |
Big thanks |
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
yep
Summary
deprecates migrate package as it's unusable now and doesn't handle webpack@5 and we can't cover all cases so it's advisable to follow migration guide, anyone who wishes to migrate to older versions can use the old published versions
Does this PR introduce a breaking change?
Not sure
Other information
/cc @alexander-akait