Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate migrate package #2313

Merged
merged 5 commits into from
Jan 9, 2021
Merged

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
yep

Summary
deprecates migrate package as it's unusable now and doesn't handle webpack@5 and we can't cover all cases so it's advisable to follow migration guide, anyone who wishes to migrate to older versions can use the old published versions

Does this PR introduce a breaking change?
Not sure

Other information
/cc @alexander-akait

@anshumanv anshumanv requested a review from a team as a code owner January 5, 2021 17:08
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #2313 (51f5648) into master (8e7fbef) will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2313      +/-   ##
==========================================
+ Coverage   67.48%   68.05%   +0.57%     
==========================================
  Files          64       52      -12     
  Lines        2519     2060     -459     
  Branches      589      508      -81     
==========================================
- Hits         1700     1402     -298     
+ Misses        819      658     -161     
Impacted Files Coverage Δ
packages/utils/src/ast-utils.ts 8.26% <0.00%> (-17.77%) ⬇️
packages/utils/src/validate-identifier.ts 8.08% <0.00%> (-14.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7fbef...51f5648. Read the comment docs.

@rishabh3112
Copy link
Member

I think we should update it for webpack@4 to webpack@5 using the migration guide https://webpack.js.org/migrate/5/.

@alexander-akait
Copy link
Member

We don't have time and enough developers to do it, so I prefer not lose time on this

@alexander-akait
Copy link
Member

And most of migrations are impossible to do due a lot of different cases

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main idea - webpack migrate still will work for current version, but we remove this package from our code and will not update anymore

@anshumanv
Copy link
Member Author

wip fixing conflicts

@anshumanv
Copy link
Member Author

@alexander-akait fixed

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix and we can merge, I think we should remove this command from CLI docs page https://webpack.js.org/api/cli/, because now it is not rerecorded to use and deprecated

@anshumanv
Copy link
Member Author

will make a PR on docs after release

alexander-akait
alexander-akait previously approved these changes Jan 8, 2021
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

alexander-akait
alexander-akait previously approved these changes Jan 8, 2021
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when CI will be green

@alexander-akait
Copy link
Member

And let's fix conflict

@alexander-akait alexander-akait merged commit b6884fa into webpack:master Jan 9, 2021
@alexander-akait
Copy link
Member

Big thanks

@anshumanv anshumanv deleted the rm-migrate branch January 9, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants