Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generators #2328

Merged
merged 5 commits into from
Jan 9, 2021
Merged

refactor: generators #2328

merged 5 commits into from
Jan 9, 2021

Conversation

rishabh3112
Copy link
Member

@rishabh3112 rishabh3112 commented Jan 8, 2021

What kind of change does this PR introduce?
refactor and type fixes

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary

  • Standardize the templates location for init-generator
  • Created template location for addon-generator
  • Cleanup and remove duplicate code by refactoring writing section
  • Explicit mention types in configtest
  • Add types for changes done to generator

Does this PR introduce a breaking change?
No

Other information
No

@rishabh3112 rishabh3112 requested a review from a team as a code owner January 8, 2021 08:16
@rishabh3112 rishabh3112 changed the title refactor: init generator refactor: generators Jan 8, 2021
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #2328 (59405be) into master (8e7fbef) will not change coverage.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2328   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files          64       64           
  Lines        2519     2519           
  Branches      589      589           
=======================================
  Hits         1700     1700           
  Misses        819      819           
Impacted Files Coverage Δ
packages/generators/addon-template/package.json.js 100.00% <ø> (ø)
packages/generators/init-template/package.json.js 100.00% <ø> (ø)
packages/generators/init-template/tsconfig.json.js 100.00% <ø> (ø)
packages/generators/src/types/index.ts 100.00% <ø> (ø)
packages/generators/src/init-generator.ts 90.00% <83.33%> (ø)
packages/configtest/src/index.ts 94.73% <100.00%> (ø)
packages/generators/src/addon-generator.ts 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7fbef...59405be. Read the comment docs.

@rishabh3112
Copy link
Member Author

/cc @alexander-akait

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add them in files

@rishabh3112
Copy link
Member Author

Don't forget to add them in files

I didn't get what you said.

@alexander-akait
Copy link
Member

look at the files field in package.json, because we should publish additional directories with package too

@rishabh3112
Copy link
Member Author

Sure, will do.

@snitin315
Copy link
Member

Canceled the run because it would have failed for webpack@latest

alexander-akait
alexander-akait previously approved these changes Jan 9, 2021
anshumanv
anshumanv previously approved these changes Jan 9, 2021
jamesgeorge007
jamesgeorge007 previously approved these changes Jan 9, 2021
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix CI

@webpack-bot
Copy link

@alexander-akait Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@alexander-akait alexander-akait merged commit 7506f07 into master Jan 9, 2021
@alexander-akait alexander-akait deleted the refactor/init-generator branch January 9, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants