-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: default loader name and plugin name #2392
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
+ Coverage 71.27% 71.74% +0.46%
==========================================
Files 46 47 +1
Lines 2155 2173 +18
Branches 568 573 +5
==========================================
+ Hits 1536 1559 +23
+ Misses 619 614 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeoman-environment
handles it already.
https://github.com/yeoman/environment/blob/main/lib/environment.js#L223
@jamesgeorge007 Good catch, maybe we just need add test(s) |
Tests are already present. Why this was included in roadmap? |
Can you provide link on tests? Maybe I something missed |
https://github.com/webpack/webpack-cli/blob/master/test/loader/loader.test.js#L22 https://github.com/webpack/webpack-cli/blob/master/test/plugin/plugin.test.js#L22 |
No tests, https://github.com/webpack/webpack-cli/blob/master/test/loader/loader.test.js#L22 is not enough for testing, it is stupid test on the question, it should be fully test with checking on files https://github.com/webpack/webpack-cli/blob/master/test/loader/loader.test.js#L43 |
Line 29 has it. |
Line 29 pass |
Loader name is not being passed as Nevertheless will add test for default loader name as well. |
af7b33d
to
dd95a1d
Compare
Thanks |
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Not needed, already present
If relevant, did you update the documentation?
No
Summary
Enforced use of process.cwd() as default
output-path
Does this PR introduce a breaking change?
No
Other information
Part of Roadmap