Show help on no command #252
Conversation
makes it so help is shown when the webpack build fails and there is no webpack.config.js possibly hide the build failing error as well? also consider showing additional information about the default configuration
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Hi @kingdaro, just noticed now that there's also another PR that tries to fix the same issue. I am confused. But I looked at the changes and it looked different from #254 ! Could you provide a small background inside the description of the PR? Please use the template provided :) |
|
Sure, updating it in just a moment. Done. It looks like they picked up the issue right as I changed my mind and decided to pick it up as well :( Either way, you can merge theirs in and close this if it looks better. |
|
Right now in this PR it shows the full help text, but I like the idea from the other PR that instead says "run again with --help for more options" for brevity. That's probably the better approach. |
There was a problem hiding this comment.
I'm going to approve this, and #254 is going to replace it if it gets attention. LGTM 
ty @kingdaro ! 😻 Before we can merge this, we have to make sure it doesn't mess with the 0CJS init
What kind of change does this PR introduce?
Shows the full help content when no arguments are given to the CLI, and when the webpack build fails.
Did you add tests for your changes?
Yes.
Summary
See #124
Before, when running the webpack build without a config, the CLI runs webpack with the default config, and fails with an unhelpful, possibly confusing error message. The original issue suggests to show help to solve this issue.
The reasons behind these specific conditions is to allow the default configuration to run as-is without arguments.
Does this PR introduce a breaking change?
No