feat: allow all css possibilities for default template #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh3112
changed the title
rishabh3112
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2544 +/- ##
==========================================
+ Coverage 90.74% 90.98% +0.23%
==========================================
Files 29 29
Lines 1459 1464 +5
Branches 416 419 +3
==========================================
+ Hits 1324 1332 +8
+ Misses 135 132 -3
Continue to review full report at Codecov.
|
rishabh3112
changed the title
|
Tests are failing because of yarn registry issues. Works fine locally. |
|
Again 😞 |
|
CI is green ✅ |
There was a problem hiding this comment.
Ready for review? I think make sense to merge firstly #2547 (review) and rewrite some tests on shapshots
alexander-akait
approved these changes
Mar 25, 2021
snitin315
approved these changes
Mar 25, 2021
|
cache problem again, should be fixed after #2553 |
anshumanv
approved these changes
Mar 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Done
If relevant, did you update the documentation?
No
Summary
Allow all possible css solutions to the users
Does this PR introduce a breaking change?
No
Other information
N/A