chore: improve sample migration output #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to change your commit format, change you rebase? It should be something like:
|
dhruvdutt
force-pushed
the
patch-1
branch
2 times, most recently
from
458d712 to
9b978f8
Compare
|
@ev1stensberg rebased and updated commit messages. 👍 |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
evenstensberg
requested changes
Feb 25, 2018
MIGRATE.md
Outdated
| @@ -153,7 +153,7 @@ module.exports = { | |||
|
|
|||
| In summary, we can see the follow changes were made | |||
| 1. The webpack schema for using loaders has changed | |||
| - `loaders` is now `module.rules` | |||
| - `module.loaders` is now `module.rules` | |||
There was a problem hiding this comment.
In webpack v1 this was loaders, please remove this
There was a problem hiding this comment.
Cleaned the commit containing that change.
| @@ -68,23 +68,23 @@ module.exports = { | |||
| The `migrate` command, when run, will show the proposed changes to the config file in the terminal, prompting the user to | |||
| accept the changes or not: | |||
|
|
|||
| ```bash | |||
| ```diff | |||
| + loader: 'babel-loader' | ||
| + }], | ||
| + options: { | ||
| - loader: ExtractTextPlugin.extract('style', 'css!sass') |
There was a problem hiding this comment.
Fixed. Updated the summary image as well. 💯
|
@dhruvdutt Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
ematipico
approved these changes
Feb 26, 2018
dhruvdutt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enhancement
Summary
Actual output:
Does this PR introduce a breaking change?
No