Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(yargs): add description for module-bind-* args #286

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

dhruvdutt
Copy link
Member

@dhruvdutt dhruvdutt commented Feb 25, 2018

What kind of change does this PR introduce?
Enhancement

Summary
Add missing description for module-bind-post and module-bind-pre arguments

Docs link for the same.

Does this PR introduce a breaking change?
No

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you point to the documentation for this? Gotta double check

@dhruvdutt
Copy link
Member Author

@ev1stensberg Updated the PR description. Here's the link again.

@evenstensberg
Copy link
Member

Can you rebase the commit to match the spec? We'll need a feat flag, but it hasn't been implemented yet

@webpack-bot
Copy link

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

@dhruvdutt dhruvdutt changed the title feat(yargs): add description for module-bind-* args misc(yargs): add description for module-bind-* args Feb 26, 2018
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@dhruvdutt
Copy link
Member Author

dhruvdutt commented Feb 26, 2018

@ev1stensberg Sorry, I didn't get what you meant here.

We'll need a feat flag, but it hasn't been implemented yet

Where do we need to implement flag? Is it something related to cz-config.js?

@evenstensberg
Copy link
Member

Lgtm

@evenstensberg evenstensberg merged commit 191b458 into webpack:master Feb 27, 2018
@dhruvdutt
Copy link
Member Author

dhruvdutt commented Feb 27, 2018

@ev1stensberg Should I setup/implement feat flag inside cz-config.js?

I think we can just rename new_feature to feat.

@dhruvdutt dhruvdutt deleted the enhance/config-yargs branch February 27, 2018 18:33
@evenstensberg
Copy link
Member

yep, up for grabs. As well as a cli() thing for bin/webpack.js changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants