Feature/setup commits validation and contributors readme #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DanielaValero
force-pushed
the
feature/setup-commits-validation-and-contributors-readme
branch
from
711da16 to
b6f8f98
Compare
3 tasks
In order to have a consistent style on the projects of webpack, we are using for the cli the settings that are used also in webpack.
DanielaValero
force-pushed
the
feature/setup-commits-validation-and-contributors-readme
branch
2 times, most recently
from
a51e888 to
84ff343
Compare
evenstensberg
requested changes
Dec 16, 2016
|
|
||
| If you are still having difficulty after looking over your configuration carefully, please post | ||
| a question to [StackOverflow with the webpack-cli tag](http://stackoverflow.com/tags/webpack-cli). Questions | ||
| that include your webpack.config.js and relevant files, this way you help others to help you. |
There was a problem hiding this comment.
Use webpack.config.js as this is a filename
There was a problem hiding this comment.
Hi, I don't understand quite right what you mean here, would you be more specific about the change ?... Ah, I got it you meant adding the quotes
There was a problem hiding this comment.
Just replace webpack.config.js with webpack.config.js 👍
|
|
||
| ## Documentation | ||
|
|
||
| webpack is insanely feature rich and documentation is a time sink. We |
There was a problem hiding this comment.
Consider rephrasing the first sentence, might be somewhat unclear what you meant
|
Checking the errors of travis |
evenstensberg
requested changes
Dec 16, 2016
| npm-debug.log | ||
| yarn-error.log |
There was a problem hiding this comment.
Should be #yarn-debug log and the log should be placed under there or you change #npm-debug log to npm and yarn-debug log
Yarn provides a good hablding of the dependencies on top of npm, using yarn has been adopted not only in the webpack project, but also lots of the loaders. In order to keep consitency across projects, adding it here also.
In order to have an automated workflow to style our code, adding now the beautifier settings of webpack.
In order to allow others to contribute to the project, we need to specify the rules and workflows with which we work. Adding them now in the right place.
In order to allow reviewers of PRs to get quicker into contex and estimate review time of a PR, adding a section to specify a branching model for the project. Basically it takes the feature and bugfix features of git-flow.
When submitting a contribution and opening a PR, the cla bot will automatically be launched. We need to explain the devs what is this about.
DanielaValero
force-pushed
the
feature/setup-commits-validation-and-contributors-readme
branch
from
84ff343 to
9b828c0
Compare
In order to have a similar structure in the commit messages of the contributions, adding a commit validation hook, that a subset of the structure of angular.js validation messages.
In order to have a similar strucuture with the core project, adding now the issue and pr templates.
evenstensberg
approved these changes
Dec 16, 2016
evenstensberg
deleted the
feature/setup-commits-validation-and-contributors-readme
branch
|
Thx! Nice work @DanielaValero ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do?
Where should the reviewer start?
How to test manually
For the yarn setup
Just follow the installation instrucctions in the contributing.
For the commit validation
Once you checked out the branch, do:
npm i: Will install the new dependencynpm run install-commit-validator: Will link to pre-commit hook the cli of the commit validatorWhere should the reviewer start?
Checking the contributor documentation