Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect negatedDescription for flags from schema #3102

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jan 23, 2022

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No
Summary

For webpack/webpack-dev-server#4216

Does this PR introduce a breaking change?
No

Other information
Internal usage.

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #3102 (9ae7efc) into master (4650e66) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3102   +/-   ##
=======================================
  Coverage   93.56%   93.57%           
=======================================
  Files          22       22           
  Lines        1617     1618    +1     
  Branches      484      483    -1     
=======================================
+ Hits         1513     1514    +1     
  Misses        104      104           
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 93.92% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4650e66...9ae7efc. Read the comment docs.

@snitin315 snitin315 marked this pull request as ready for review January 24, 2022 11:35
@snitin315 snitin315 requested a review from a team as a code owner January 24, 2022 11:35
@alexander-akait
Copy link
Member

@snitin315 Feel free to ping me when it will be green and merged, I will do relesae

@snitin315 snitin315 merged commit 463b731 into master Jan 24, 2022
@snitin315 snitin315 deleted the fix-negative-des branch January 24, 2022 12:09
@snitin315
Copy link
Member Author

@alexander-akait done

@dmvol81
Copy link

dmvol81 commented Feb 11, 2022

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

No

If relevant, did you update the documentation?

No

Summary

For webpack/webpack-dev-server#4216

Does this PR introduce a breaking change?

No

Other information

Internal usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants